Saved filename fixed so that clients display it correctly #2415 #2705
Conversation
ghost
added
the
| // This makes file name property extraction for display in clients such as Parse Dashboard to work correctly. | ||
| // We can not use an UUID with dashes here because it is already used for files.parse.com hosted files and | ||
| // expandFilesInObject method below uses this distinction to construct the correct url for the file. | ||
| filename = randomHexString(36) + '_' + filename; |
There was a problem hiding this comment.
Why not use a real UUID instead of a random hex? (32 chars + 4 dash right?)
There was a problem hiding this comment.
As explained in the comment, if we use a UUID, expandFilesInObject method will think the file is hosted in files.parse.com and construct the wrong URL. We want to keep the support for files.parse.com files and Parse Server created files so this keeps both working.
There was a problem hiding this comment.
if you look at the regex here https://github.com/ParsePlatform/parse-server/blob/e690b73bb5982cb8c8766e92c44e09f6dcd9aa99/src/Controllers/FilesController.js#L9
the separator between the UUID and the rest of the file is a - .
IN our case we use a _ for separating the random string and the filename. So that would still work
There was a problem hiding this comment.
That's true. So I can do something like this:
var hexstring = randomHexString(32)
var uuid = hexstring.substring(0,8) + "-" + hexstring.substring(8,12) + "-" + hexstring.substring(12,16) + "-" + hexstring.substring(16,20) + "-" + hexstring.substring(20);
filename = uuid + '_' + filename;
There was a problem hiding this comment.
maybe add the uuid package to generate a true UUID. (https://github.com/broofa/node-uuid)
There was a problem hiding this comment.
ok. will do. thanks.
Current coverage is 92.21% (diff: 100%)@@ master #2705 diff @@
==========================================
Files 102 102
Lines 12446 12447 +1
Methods 1559 1559
Messages 0 0
Branches 2039 2039
==========================================
Hits 11478 11478
- Misses 968 969 +1
Partials 0 0
|
…lama-buddy/parse-server into extend-uploaded-filename-length
|
@lama-buddy updated the pull request - view changes |
The fix:
The saved filename is changed to the following format: UUID_originalfilename
The names of files hosted in files.parse.com have the following format: UUID-originalfilename
The character that follows the UUID in the filenames (underscore and dash) is what allows the expandFilesInObject method to distinguish between Parse Server created/migrated files from files hosted on files.parse.com and generate the correct file URL.